Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Properties (custom_property and custom_property_values events) #500

Merged
merged 9 commits into from
May 9, 2024

Conversation

colbylwilliams
Copy link
Contributor

Related to issue #416 and PR #417


Before the change?

After the change?

  • Includes test (GA'd) payloads for both custom_property and custom_property_values events
  • Updates the models for both events to correctly deserialize the event payloads
  • Adds custom_property and custom_property_values events to app events (subscriptions)
  • Adds organization_custom_properties and repository_custom_properties app permissions
  • Adds custom_properties field to Repository

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Copy link

github-actions bot commented May 9, 2024

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@JamieMagee JamieMagee merged commit 9fc75ba into octokit:main May 9, 2024
9 checks passed
@JamieMagee
Copy link
Contributor

Thanks for the PR. This change is included in v2.2.1.

@colbylwilliams colbylwilliams deleted the custom-properties-v2 branch June 5, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants