Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Workflows associated to deployment environments #260

Merged
merged 3 commits into from
Apr 27, 2023

Conversation

lineville
Copy link
Contributor

Resolves #258, #259


Behavior

Before the change?

  • No model to support the WorkflowJobWaiting event.
  • No deployment property included in WorkflowJob payloads.

After the change?

  • Adds support for the WorkflowJobWaitingEvent which will get triggered when a job enters a waiting state which can occur if a job is associated to an environment that requires a manual approval.
  • Includes a deployment node to the WorkflowJobPayload which will be present when a workflow is associated to an environment.

Other information

  • Two additional unit tests have been added to cover these changes, all existing tests still pass 🧪

Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

@JamieMagee
Copy link
Contributor

I'll merge this shortly and release version 1.5.1.

@lineville
Copy link
Contributor Author

@JamieMagee Awesome! Thanks so much for the quick turn around ♥️

@JamieMagee JamieMagee enabled auto-merge (squash) April 27, 2023 20:30
@JamieMagee JamieMagee merged commit 00bc575 into octokit:main Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[FEAT]: Support WorkflowJob Waiting Event
2 participants