feat(typescript): compile-time missing secret error

[jablko]

Should this be a compile-time as well as a run-time error?

--- a/test/unit/middleware-constructor-test.ts
+++ b/test/unit/middleware-constructor-test.ts
@@ -1,5 +1,6 @@
 import { createMiddleware as Middleware } from "../../src/middleware";
 
 test("options: none", () => {
+  // @ts-expect-error
   expect(() => Middleware({})).toThrow();
 });

[G-Rath]

Suggested change

	const state = {
	const state: State & { secret: string }= {

This needs to be explicitly typed as it's an object

[jablko]

I've applied this change although I confess I don't understand it: why do objects need to be explicitly typed?

[jablko]

Answered in #466 (comment), thanks!

[gr2m]

Thanks! We shoudl have that a long time ago! I am sure we will be able to make the types much more elegant once we split out the event handling into its own module

resolved

[github-actions]

🎉 This PR is included in version 8.10.0 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀