-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(typescript): better payload definitions #409
Conversation
Should this be merged in the meantime until the new types from |
@wolfy1339 there shouldn't be harm in doing so, just needs the conflicts resolved 🤷 (both the |
@octokit/webhook-definitions
@octokit/webhook-definitions
@gr2m It seems there's a problem with the tests. They don't seem to be running at all |
@wolfy1339 weirdly I just noticed that my CI checks don't seem to have ever run for the PRs created by the action on my function repo (i.e G-Rath/compare-gh-webhook-to-schema-function#35) - I've got no idea what difference there is that means the CI rules I've got setup are not being met. Might be the two are related? |
Hmm I don't know why the tests are not running, very odd! We do use a personal access token to create / update this pull request, so it should not be caused by the limitations that a github action cannot trigger another github action (when using Update: fixed by pushing an empty commit (7eaa7af), must have been a temporary hiccup? |
Superseded by #406 |
A new release of @octokit/webhooks was just released 👋🤖
This pull request updates the TypeScript definitions derived from
@octokit/webhooks
. I can't tell if the changes are fixes, features or breaking, you'll have to figure that out on yourself and adapt the commit messages accordingly to trigger the right release, see our commit message conventions.View rendered README.md