feat(typescript): type algorithm property for sign options
#377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If I understand correctly, this will improve the typing of the |
gr2m
added
Type: Feature
gr2m
changed the title
algorithm property for sign optionsalgorithm property for sign options
G-Rath
force-pushed
the
type-sign-algorithm
branch
from
a6f44df to
afa13ee
Compare
G-Rath
force-pushed
the
type-sign-algorithm
branch
from
afa13ee to
f45389f
Compare
gr2m
approved these changes
Dec 6, 2020
|
🎉 This PR is included in version 7.17.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've done it like this because if you do just
AlgorithmTS won't let you pass it in as just a string - you'll have to always use theAlgorithmenum.While this isn't a bad thing (since the enum is exported), it'd be a change for TS users - this way you can pass both the enum and plain strings without being able to pass just any old string.
Another way around this would be to make
Algorithmaconstenum, but then that'd break people who are currently importing and using the enum since it would no longer exist at runtime.These changes could be made later down the line if desired, such as if a major release is done.