refactor: use node: specifier imports and full relative paths imports, update tests for new type errors
#653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfy1339
added
the
Type: Maintenance
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with |
wolfy1339
force-pushed
the
node-module-imports
branch
5 times, most recently
from
37bbf1a to
4c13a54
Compare
wolfy1339
force-pushed
the
node-module-imports
branch
from
4c13a54 to
474744c
Compare
nickfloyd
approved these changes
Nov 28, 2023
wolfy1339
changed the title
node: specifier importsnode: specifier imports and full relative paths imports
wolfy1339
changed the title
node: specifier imports and full relative paths importsnode: specifier imports and full relative paths imports, update tests for new type errors
|
Currently blocked on #654 |
4 tasks
|
🎉 This PR is included in version 8.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 8.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces NodeJS internal module imports with
node:specifier imports.