Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency @octokit/tsconfig to v2 #340

Merged
merged 3 commits into from
Jun 13, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 6, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@octokit/tsconfig ^1.0.2 -> ^2.0.0 age adoption passing confidence

Release Notes

octokit/tsconfig

v2.0.0

Compare Source

Features
BREAKING CHANGES
  • this will throw errors during Typescript compilation when types are not imported using the import type keywords.

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Jun 6, 2023
@renovate renovate bot force-pushed the renovate/octokit-tsconfig-2.x branch from 8788e98 to 95ab000 Compare June 9, 2023 23:16
@renovate renovate bot force-pushed the renovate/octokit-tsconfig-2.x branch from 95ab000 to 526d620 Compare June 12, 2023 16:58
@wolfy1339
Copy link
Member

We shouldn't need to use CommonJS require here. All the other modules use the import/export syntax

Revert updates to source and test files made in 39af71a
@renovate
Copy link
Contributor Author

renovate bot commented Jun 13, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@wolfy1339
Copy link
Member

We were using the ts-config template for jest, that's something to watch out for in these PRs when updating @octokit/tsconfig as not all of them removed the preset when switching to esbuild @kfcampbell

@wolfy1339 wolfy1339 merged commit 68e7ff9 into main Jun 13, 2023
@wolfy1339 wolfy1339 deleted the renovate/octokit-tsconfig-2.x branch June 13, 2023 22:26
@kfcampbell
Copy link
Member

@wolfy1339 thanks for the reminder! I forgot about that detail. I'll keep an eye out in the future on these renovate PRs.

@github-actions
Copy link

🎉 This PR is included in version 4.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants