Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update scripts to ESM, cleanup deps #681

Merged
merged 10 commits into from
Oct 2, 2023
Merged

build: update scripts to ESM, cleanup deps #681

merged 10 commits into from
Oct 2, 2023

Conversation

wolfy1339
Copy link
Member

Resolves #ISSUE_NUMBER


Before the change?

  • An unused script was laying around
  • Scripts were written to use CJS
  • There was an unused devDep
  • The dependency on sort-keys was blocked to v4

After the change?

  • The unused script is now removed
  • Scripts are now written in ESM
  • Unused dependencies were removed
  • The dependency on sort-keys can now be upgraded to any further version

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@wolfy1339 wolfy1339 added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Sep 30, 2023
@github-actions
Copy link
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@wolfy1339 wolfy1339 merged commit 82a26ac into main Oct 2, 2023
10 checks passed
@wolfy1339 wolfy1339 deleted the esm-scripts branch October 2, 2023 20:03
@github-actions
Copy link
Contributor

🎉 This PR is included in version 10.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants