Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @octokit/core as peerDependency #207

Closed
gr2m opened this issue Aug 26, 2020 · 1 comment · Fixed by #296
Closed

Add @octokit/core as peerDependency #207

gr2m opened this issue Aug 26, 2020 · 1 comment · Fixed by #296
Labels
Type: Bug Something isn't working as documented

Comments

@gr2m
Copy link
Contributor

gr2m commented Aug 26, 2020

This is a follow up issue to octokit/plugin-paginate-rest.js#124 (comment)

We need to add @octokit/core as a peerDependency to address a problem with yarn 2. It is something I planned to do anyway, but wanted to figure out automated testing to assure compatibility of the plugins with the latest @octokit/core.

I only want to define compatibility with the lowest version, in this case v3. Compare pull request https://github.com/octokit/plugin-paginate-rest.js/pull/130/files.

I would appreciate help, this is a great issue for a first-time contributor
@gr2m gr2m added the Type: Bug Something isn't working as documented label Sep 10, 2020
@JumpLink JumpLink mentioned this issue Dec 3, 2020
Merged
JumpLink added a commit to ribajs/riba that referenced this issue Dec 3, 2020
@JumpLink
[Shopify/BuildSystem] Stop work on github theme upload until a fix is…
d0d68dc 
… merged

Wait for fix: octokit/plugin-rest-endpoint-methods.js#207
Pull Request: octokit/plugin-rest-endpoint-methods.js#296
@gr2m gr2m closed this as completed in #296 Dec 3, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2020

🎉 This issue has been resolved in version 4.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Something isn't working as documented
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(package): add @octokit/core as peer dependency ArtCodeStudio/plugin-rest-endpoint-methods.js
1 participant
@gr2m