Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): replace Pika with esbuild and tsc #527

Merged
merged 8 commits into from
May 19, 2023
Merged

fix(build): replace Pika with esbuild and tsc #527

merged 8 commits into from
May 19, 2023

Conversation

wolfy1339
Copy link
Member

Pika has been deprecated for a while now, and the project has now been archived, and because of that the released npm package is missing most of the files generated by the build step.

Uses esbuild to transpile the TS source code into an ESM source, NodeJs bundle, and a browser bundle

Uses the TypeScript compiler to generate the types

Behavior

Before the change?

  • Uses pika for the build system
  • The released npm package is missing most of the files generated by the build step. dist-node, dist-types, dist-web... even though they are generated correctly.

After the change?

  • Uses esbuild to generate the JS bundles
  • Uses the TypeScript compiler to generate the type definitions
  • The correct file matching patterns are used so we publish all the necessary files again.

Other information

Additional info

This should be merged as a patch release so that we can more easily pinpoint an issue with this PR should one arise

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Dependencies/code cleanup: Type: Maintenance

@wolfy1339 wolfy1339 added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label May 17, 2023
kfcampbell
kfcampbell previously approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @wolfy1339! You rock.

@wolfy1339
Copy link
Member Author

I pushed another commit, since type import exports need to be explicitly marked

@kfcampbell
Copy link
Member

Oh shoot, I'm sorry. I merged a bot update to bump @octokit/types. Would you prefer to fix the merge conflicts or should I?

@wolfy1339
Copy link
Member Author

Merge conflicts are gone

kfcampbell
kfcampbell approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wolfy1339 wolfy1339 merged commit 3ba0db6 into main May 19, 2023
@wolfy1339 wolfy1339 deleted the esbuild branch May 19, 2023 20:47
@github-actions
Copy link
Contributor

🎉 This PR is included in version 6.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfcampbell kfcampbell kfcampbell approved these changes

Assignees
No one assigned
Labels
released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
🧰 Octokit Active
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wolfy1339 @kfcampbell