Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate events and checks client #1195

Merged
merged 11 commits into from
Feb 12, 2020
Merged

Generate events and checks client #1195

merged 11 commits into from
Feb 12, 2020

Conversation

indigok
Copy link

@indigok indigok commented Feb 9, 2020

Part of #1157. Generalizes the openapi_generator to work with the events and checks clients and removes hard coded values from the tests. The major changes are replacing check_run in method names to just check:

events.rb

repository_events => repo_events
organization_events => org_events, also adds user param
organization_public_events => org_public_events

the same:
public_events, user_events, user_public_events,

checks.rb

create_check_run => create_check
update_check_run => update_check
check_runs_for_check_suite => check_suites
check_run => check
check_run_annotations => check_annotations
set_check_suite_preferences => set_suite_preferences

the same:
check_suite, create_check_suite, rerequest_check_suite

Methods removed for now as they'll be generated in other files,
received_events, received_public_events(user.rb),
repository_network_events (networks.rb)
repository_issue_events => repository_events (issues.rb)
issue_events, issue_event (issues.rb)
check_runs_for_ref, check_suites_for_ref (commits.rb)

Retroactively:

move_project_column and move_project_card now return a boolean response

Copy link
Member

@tarebyte tarebyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

lib/octokit/client/checks.rb Outdated Show resolved Hide resolved
spec/octokit/client/checks_spec.rb Show resolved Hide resolved
spec/openapi_client_generator_spec.rb Outdated Show resolved Hide resolved
@indigok indigok requested a review from tarebyte February 11, 2020 21:22
@indigok indigok merged commit 429f803 into master Feb 12, 2020
@indigok indigok deleted the events-checks branch February 12, 2020 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants