Generate hooks client #1161
Merged
Generate hooks client #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds default hash and missing key error Co-Authored-By: Mark Tareshawty <[email protected]>
tarebyte
approved these changes
Nov 15, 2019
| # @return [Boolean] True if hook removed, false otherwise. | ||
| # @param repo [Integer, String, Repository, Hash] A GitHub repository | ||
| # @param hook_id [Integer] The ID of the hook | ||
| # @return <Boolean> True on success, false otherwise |
There was a problem hiding this comment.
Looks like this should be
Suggested change
| # @return <Boolean> True on success, false otherwise | |
| # @return [Boolean] True on success, false otherwise |
spec/octokit/client/hooks_spec.rb
Outdated
| context "with repository" do | ||
| before(:each) do | ||
| @repo = @client.create_repository("an-repo") | ||
| @repo = @client.create_repository("a-repo") |
There was a problem hiding this comment.
Do we maybe want to use the already created repo?
spec/octokit/client/hooks_spec.rb
Outdated
| end | ||
|
|
||
| describe ".create_hook", :vcr do | ||
| it "creates a hook" do | ||
| assert_requested :post, github_url("/repos/#{@repo.full_name}/hooks") | ||
| end | ||
| it "returns with no config url passed" do | ||
| expect { @client.create_hook(@repo.full_name)}.to raise_error Octokit::MissingKey |
added 2 commits
November 18, 2019 11:35
Return type formatting + test repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1157. Continues to generalize the
openapi_client_generatorand generates thehooks.rbclient.There are breaking changes as a few of the method definitions have changed, however the underlying api calls appeared to have changed and the old methods don't completely work. This does removes support for service hooks (which aren't supported in general anymore) and
parse_payloadwhich is a helper function. Also,remove_hookis nowdelete_hookandtest_hookistest_push_hookas these more closely resemble the API.This also retroactively affects the previous generated clients as we changed list calls to
paginate.TODOs:
hooks_specandopenapi_client_generator_spec