Provided a httpclient timeout option #965
Conversation
The `HttpClient` does not take the `Timeout` argument which by default is 100 seconds. Implemented a change where the user has an option to provide the timeout. This is to address the octokit#963.
|
Yeah, this is something I'd like to make available to consumers - I've just been grappling with how to get there due to how we're currently using Your solution highlights the pain we're currently in with respect to overloads to It's been almost six months since I last thought about this, so I'll go back to this and revisit that topic. |
|
Wasn't aware of that. |
| @@ -130,6 +131,10 @@ public static IGitHubClient GetAnonymousClient() | |||
| { | |||
| return new GitHubClient(new ProductHeaderValue("OctokitTests")); | |||
| } | |||
| public static IGitHubClient GetAnonymousClient(TimeSpan httpTimeout) | |||
There was a problem hiding this comment.
Please separate methods with newlines.
Included a line break in between methods.
Removed the additional line break.
Included a line break in between methods.
Removed the additional line break.
|
Fixed the line breaks and spaces. @shiftkey Will the CodeFormatter address these line breaks and spaces? |
|
@naveensrinivasan @haacked yes, if you're on VS2015 you should be able to run it from the command line: If that's not working As Advertised™, I can investigate further. |
|
When I branched the VS2015 branch wasn't available. Will do that going forward. Thanks! |
|
@naveensrinivasan first off, thanks for working on this. I should have made my reservations about adding another I'm not enthusiastic about adding in yet another So, while I feel awful for closing this PR, I'm trying to make amends by opening a discussion about making the whole HTTP stack more friendly to Octokit consumers #984. I've also opened the first PR which takes us down that path #985 so we can talk about tangible things. I'd love your feedback on either (or both!) topic, as I don't think there's as much work involved as I previously expected - we just need to sit down and work through it... |
|
@shiftkey Not an issue. 👍 |
The
HttpClientdoes not take theTimeoutargument which by default is 100 seconds. Implemented a change where the user has an option to provide the timeout. This is to address the #963.