VS2015 migration #956
Merged
VS2015 migration #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiftkey
force-pushed
the
vs2015-support
branch
from
e23d4bd to
bcef9b6
Compare
|
Nice! I know @Eilon was just asking me if we could switch Octokit.net to VS 2015. I think he even offered to help. 😛 |
|
@haacked it looks like the xml-doc warnings are causing the build to fail incorrectly. I really don't want to go through and triage it all, but maybe I have to? |
|
I would set the doc warnings as warnings and not errors and assign it to me to fix later. |
|
@haacked good point, I'll do that now and see if the build is happy with that... |
shiftkey
force-pushed
the
vs2015-support
branch
from
3f96554 to
bfb0559
Compare
|
Looks |
to me!
|
|
|
👍 |
This was referenced Dec 22, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
netcore45->netcore451target it any more