-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepping searching code doc #955
Conversation
In = new[] { CodeInQualifier.File }, | ||
|
||
// or we can search the file and the path too | ||
In = new[] { CodeInQualifier.File, CodeInQualifier.Path }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer code that would compile. This one will fail to compile because there is duplication of In
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I think we should keep this second line around instead of both
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
The above sample does not produce a result. My two cents we should have a sample that produces some result. |
Granted it does not compile, however documentation is generally letting the user know how to use the api in a more digestible way. I see the docs as complementing the code and tests. There have been too many times where I do not have a clue about a library, I simply want to pick up an example that just works. I do agree that maybe after each feature we have a working example? Or simply a few working examples in it's own tab? cc/ @shiftkey |
I think this is a nice goal, but perhaps we can address this elsewhere - with more interactive or detailed examples? For these sections, we should be focusing on understanding the API options available. |
Thanks! |
Searching tha code docs.