-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arbitrarymarkdown #947
Arbitrarymarkdown #947
Conversation
…te with existing syntax. it generates a CA1502 code excessive complexity warning and i suppressed it.
…ys false any more. octokit#867
…unit tests for it.
@@ -37,7 +37,6 @@ public PullRequestsClientTests() | |||
var result = await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest); | |||
|
|||
Assert.Equal("a pull request", result.Title); | |||
Assert.False(result.Merged); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems unrelated to the other changes - could you add it back in?
There seems to be some changes in here related to the issue search. Could you refresh my memory on which issue those changes are addressing? |
@chenjiaming93 Given there's some other branches for Pull Request Assignee and Pull Request Merged, you could have a go at rewriting this branch to contain just those commits. I'll walk you through the process to explain what's happening. You should have a remote named
If you only see
And now you've done that, ensure you've got the latest changes from both repositories:
We'll switch to our branch we're working on:
And we're going to put it back to whatever is the latest from upstream:
If at this point you feel unsure about continuing, this is how you get back to your previous state:
Now, we're going to add those three commits onto our new branch:
Once you've tested out things with a
|
@shiftkey no problem. I will do that. Thx |
Closing in favour of #957 |
Let us see if #904 still happens
Fixes #938
Supersedes #939