Pullrequestmerged #936
Pullrequestmerged #936
Conversation
…te with existing syntax. it generates a CA1502 code excessive complexity warning and i suppressed it.
…ys false any more. #867
| @@ -34,7 +34,7 @@ public PullRequest(Uri url, Uri htmlUrl, Uri diffUrl, Uri patchUrl, Uri issueUrl | |||
| Base = @base; | |||
| User = user; | |||
| MergeCommitSha = mergeCommitSha; | |||
| Merged = merged; | |||
| Merged = merged || MergedAt.HasValue; | |||
There was a problem hiding this comment.
Let's completely remove the merged constructor parameter. Merged will be a calculated property. So this should be Merged = MergedAt.HasValue.
|
Howdy folks, I was just digging into this issue myself (merged always being false on all pull request, even those that have been merged) and came across this PR as well as 2 issues and some other PRs etc. It seems in the various shuffling that change Merged field to be a calculated field hasnt actually made it through Is the best course of action for someone to submit a new PR or can this current one be updated and merged in? If you want me to do it let me know. In the meantime I can obviously use the workaround of pr.MergedAt.HasValue Cheers |
|
This PR appears to be abandoned. I'm opening up a new one #970 to supersede this one. |
#867.
Set Merged to be Merged||MergedAt.HasValue. Merged is not always FALSE anymore.