Adds overloads to GetArchive for adding custom timeouts #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heytherewill
changed the title
| /// <param name="reference">A valid Git reference.</param> | ||
| /// <param name="timeout"> Timeout in minutes </param> | ||
| /// <returns>The binary contents of the archive</returns> | ||
| IObservable<byte[]> GetArchive(string owner, string name, ArchiveFormat archiveFormat, string reference, int timeout); |
There was a problem hiding this comment.
Honestly, I'd rather not have this method and only have the TimeSpan I think it promotes better practices. Also, if we really want this overload, we can add it as an extension method to the interface.
Plus extra ensures
|
hmm, it seems like the build failed due to #904 |
heytherewill
changed the title
|
Apologies for the delay, and thanks for working on this!
|
shiftkey
added a commit
that referenced
this pull request
Nov 4, 2015
Adds overloads to GetArchive for adding custom timeouts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (hopefully) fixes #817