-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add helper class for creating web hooks #917
Conversation
Funny you should mention this. I just submitted a PR that includes some guidelines around our model objects. https://github.com/octokit/octokit.net/blob/consolidate-committer-info/Octokit/Models/README.md For request objects (such as this), I think optional parameters should simply be read/write properties and required parameters are read only and go in the constructor. Does that make sense? |
👍 will update PR tonight |
01ec4f6
to
8c962d8
Compare
Also added a method, Failing test is the known |
public string Secret { get; set; } | ||
|
||
/// <summary> | ||
/// Gets wether the SSL certificate of the host will be verified when |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/wether/whether
We now throw an exception with a more helpful message if the user has added any webhook specific config values to the Come to think of it, I need to do a bit of refactoring to clean this up a bit... |
d442b24
to
b0ccf1a
Compare
I think this is now done, just awaiting the ✅ of approval from AppVeyor |
Looks like there's a csproj merge conflict here 😢 |
crap, totally missed your comment... 😞 will try and fix it up as soon as possible. |
5a6c4a5
to
e643534
Compare
OK, merge conflicts sorted, now just waiting for AppVeyor |
I don't think that second build is ever going to complete, so I'm gonna merge this in. Thanks again @alfhenrik! |
Add helper class for creating web hooks
👍 |
Introducing
NewRepositoryWebHook
, a new strongly typed class that derives from the existingNewRepositoryHook
class but adds properties and constructor parameters for config settings that should be passed to the API when creating a new web hook. These settings are merged with the config settings that are specific to the web service the web hook will be interacting with (as per https://api.github.com/hooks).Fixes #914