[WIP] Add new org api parameters #912
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@haacked I had a go at rebasing this branch but encountered some conflicts. I'm not sure I was doing it right - would love some feedback on bringing this up to date. |
Type and Affiliation/Visibility are exclusive, if one is set the other can't be, so the enum properties have to be nullable. The default behaviour when no parameters are passed is whatever the new default behaviour is on the server for the new api (currently, it is Visibility = All and Affiliation = Owner | Collaborator.
|
I knew this PR looked familiar! Let's close this out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeandAffiliation/Visibilityare exclusive, if one is set the othercan't be, so the enum properties have to be nullable. The default
behaviour when no parameters are passed is whatever the new default
behaviour is on the server for the new api (currently, it is
Visibility=AllandAffiliation=Owner | Collaborator).Replaces PR #780