893 readonlypagecollection null body #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sAResponseWithANullBody
| @@ -11,7 +11,7 @@ public class ReadOnlyPagedCollection<T> : ReadOnlyCollection<T>, IReadOnlyPagedC | |||
| readonly Func<Uri, Task<IApiResponse<List<T>>>> _nextPageFunc; | |||
|
|
|||
| public ReadOnlyPagedCollection(IApiResponse<List<T>> response, Func<Uri, Task<IApiResponse<List<T>>>> nextPageFunc) | |||
| : base(response != null ? response.Body : new List<T>()) | |||
| : base(response != null ? response.Body ?? new List<T>() : new List<T>()) | |||
There was a problem hiding this comment.
Now I really understand the power of the ?. operator
There was a problem hiding this comment.
We could probably upgrade our compiler to use C# 6 if someone wants to take a crack at it. As long as we don't break our other platforms.
haacked
added a commit
that referenced
this pull request
Sep 17, 2015
…l-body 893 readonlypagecollection null body
|
|
|
This is now live on NuGet as of version |
|
👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #893