Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'closed_at' to reflect latest changes in the milestones-api #890

Merged
merged 1 commit into from
Sep 17, 2015
Merged

Add 'closed_at' to reflect latest changes in the milestones-api #890

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Octokit/Models/Response/Milestone.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public Milestone(int number)
Number = number;
}

public Milestone(Uri url, int number, ItemState state, string title, string description, User creator, int openIssues, int closedIssues, DateTimeOffset createdAt, DateTimeOffset? dueOn)
public Milestone(Uri url, int number, ItemState state, string title, string description, User creator, int openIssues, int closedIssues, DateTimeOffset createdAt, DateTimeOffset? dueOn, DateTimeOffset? closedAt)
{
Url = url;
Number = number;
Expand All @@ -26,6 +26,7 @@ public Milestone(Uri url, int number, ItemState state, string title, string desc
ClosedIssues = closedIssues;
CreatedAt = createdAt;
DueOn = dueOn;
ClosedAt = closedAt;
}

/// <summary>
Expand Down Expand Up @@ -78,6 +79,11 @@ public Milestone(Uri url, int number, ItemState state, string title, string desc
/// </summary>
public DateTimeOffset? DueOn { get; protected set; }

/// <summary>
/// The date, if any, when this milestone was closed.
/// </summary>
public DateTimeOffset? ClosedAt { get; protected set; }

internal string DebuggerDisplay
{
get { return String.Format(CultureInfo.InvariantCulture, "Title {0} ", Title); }
Expand Down