Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for the comments URL not surfaced in the issue response #884

Merged
merged 1 commit into from
Sep 9, 2015
Merged

Fixes for the comments URL not surfaced in the issue response #884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Octokit.Tests/Clients/IssuesClientTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,7 @@ public void CanDeserializeIssue()

Assert.Equal(new Uri("https://api.github.com/repos/octokit-net-test/public-repo-20131022050247078/issues/1"), response.Body.Url);
Assert.Equal(new Uri("https://github.com/octokit-net-test/public-repo-20131022050247078/issues/1"), response.Body.HtmlUrl);
Assert.Equal(new Uri("https://api.github.com/repos/octokit-net-test/public-repo-20131022050247078/issues/1/comments"), response.Body.CommentsUrl);
}
}
}
8 changes: 7 additions & 1 deletion Octokit/Models/Response/Issue.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,11 @@ public class Issue
{
public Issue() { }

public Issue(Uri url, Uri htmlUrl, int number, ItemState state, string title, string body, User user, IReadOnlyList<Label> labels, User assignee, Milestone milestone, int comments, PullRequest pullRequest, DateTimeOffset? closedAt, DateTimeOffset createdAt, DateTimeOffset? updatedAt)
public Issue(Uri url, Uri htmlUrl, Uri commentsUrl, int number, ItemState state, string title, string body, User user, IReadOnlyList<Label> labels, User assignee, Milestone milestone, int comments, PullRequest pullRequest, DateTimeOffset? closedAt, DateTimeOffset createdAt, DateTimeOffset? updatedAt)
{
Url = url;
HtmlUrl = htmlUrl;
CommentsUrl = commentsUrl;
Number = number;
State = state;
Title = title;
Expand All @@ -41,6 +42,11 @@ public Issue(Uri url, Uri htmlUrl, int number, ItemState state, string title, st
/// </summary>
public Uri HtmlUrl { get; protected set; }

/// <summary>
/// The Comments URL of this issue.
/// </summary>
public Uri CommentsUrl { get; protected set; }

/// <summary>
/// The issue number.
/// </summary>
Expand Down