Handle empty content better #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We didn't handle the 204 response properly for the `StatisticsClient`. Now we do. Fixes #836
Also refactored the code to be a bit easier to understand and have less calculations.
Most calls to `GetQueuedOperation` are used to queue up an operation that'll return a collection in a subsequent call. In the case that the API returns No Content, we want to return an empty collection. This refactoring embeds that last bit of logic into `GetQueuedOperation` rather than making every caller have to do it.
It doesn't follow the pattern of most of our other clients.
|
@shiftkey you ok with this? |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #836
If we get a 204 No Content response to GetQueuedContent, we should return an empty collection rather than throw an exception.