Implement Repository Deploy Keys client #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As this is just waiting for me to do integration tests, the main changes are ready for review if someone has the time. 😁 |
|
Looks great! Any idea when you'll get to the integration tests? |
|
I'll try and get them done in the next couple of days |
hnrkndrssn
changed the title
|
Integration tests are now dun! 😄 // @haacked |
|
That failure seems unrelated to your work. Thanks! |
| /// See the <a href="https://developer.github.com/v3/repos/keys/">Repository Deploy Keys API documentation</a> for more information. | ||
| /// </remarks> | ||
| IObservableRepositoryDeployKeysClient DeployKeys { get; } | ||
|
|
There was a problem hiding this comment.
No need for this newline between the closing semi-colon and the code above.
|
|
|
@haacked anything else missing before this can be merged? |
haacked
added a commit
that referenced
this pull request
Jul 3, 2014
Implement Repository Deploy Keys client
|
Whoops, I thought I had merged it, but I got distracted. 😄 |
|
💖 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #335
http://developer.github.com/v3/repos/keys/#edit