Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2927: comment id model update to long instead of int #2928

Merged
merged 8 commits into from
Jun 10, 2024
Merged

#2927: comment id model update to long instead of int #2928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4f3c8e8
#2927: comment id model update to long instead of int
arxange1 Jun 4, 2024
4b2e677
#2927: code review fixes (1)
arxange1 Jun 5, 2024
fe329e7
#2927: code review fixes (2)
arxange1 Jun 5, 2024
3022734
#2927: comment id model update to long instead of int: unit tests fix
arxange1 Jun 6, 2024
1977413
Merge branch 'main' into bugfix/#2927
arxange1 Jun 6, 2024
f5d035b
#2927: code review fixes
arxange1 Jun 6, 2024
10dc141
Merge branch 'bugfix/#2927' of https://github.com/arxange1/octokit.ne…
arxange1 Jun 6, 2024
b52b57c
Fixed most names of parameters
BrianCArnold Jun 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions Octokit.Reactive/Clients/IObservableCommitCommentReactionsClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,60 +17,60 @@ public interface IObservableCommitCommentReactionsClient
/// <remarks>https://developer.github.com/v3/reactions/#create-reaction-for-a-commit-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <param name="reaction">The reaction to create </param>
/// <returns></returns>
IObservable<Reaction> Create(string owner, string name, int number, NewReaction reaction);
IObservable<Reaction> Create(string owner, string name, long commentId, NewReaction reaction);

/// <summary>
/// Creates a reaction for a specified Commit Comment
/// </summary>
/// <remarks>https://developer.github.com/v3/reactions/#create-reaction-for-a-commit-comment</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <param name="reaction">The reaction to create </param>
/// <returns></returns>
IObservable<Reaction> Create(long repositoryId, int number, NewReaction reaction);
IObservable<Reaction> Create(long repositoryId, long commentId, NewReaction reaction);

/// <summary>
/// List reactions for a specified Commit Comment
/// </summary>
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-a-commit-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <returns></returns>
IObservable<Reaction> GetAll(string owner, string name, int number);
IObservable<Reaction> GetAll(string owner, string name, long commentId);

/// <summary>
/// List reactions for a specified Commit Comment
/// </summary>
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-a-commit-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <param name="options">Options for changing the API response</param>
/// <returns></returns>
IObservable<Reaction> GetAll(string owner, string name, int number, ApiOptions options);
IObservable<Reaction> GetAll(string owner, string name, long commentId, ApiOptions options);

/// <summary>
/// List reactions for a specified Commit Comment
/// </summary>
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-a-commit-comment</remarks>
/// <param name="repositoryId">The owner of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <returns></returns>
IObservable<Reaction> GetAll(long repositoryId, int number);
IObservable<Reaction> GetAll(long repositoryId, long commentId);

/// <summary>
/// List reactions for a specified Commit Comment
/// </summary>
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-a-commit-comment</remarks>
/// <param name="repositoryId">The owner of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <param name="options">Options for changing the API response</param>
/// <returns></returns>
IObservable<Reaction> GetAll(long repositoryId, int number, ApiOptions options);
IObservable<Reaction> GetAll(long repositoryId, long commentId, ApiOptions options);

/// <summary>
/// Deletes a reaction for a specified Commit Comment
Expand All @@ -81,7 +81,7 @@ public interface IObservableCommitCommentReactionsClient
/// <param name="commentId">The comment id</param>
/// <param name="reactionId">The reaction id</param>
/// <returns></returns>
IObservable<Unit> Delete(string owner, string name, int commentId, int reactionId);
IObservable<Unit> Delete(string owner, string name, long commentId, long reactionId);

/// <summary>
/// Deletes a reaction for a specified Commit Comment
Expand All @@ -91,6 +91,6 @@ public interface IObservableCommitCommentReactionsClient
/// <param name="commentId">The comment id</param>
/// <param name="reactionId">The reaction id</param>
/// <returns></returns>
IObservable<Unit> Delete(long repositoryId, int commentId, int reactionId);
IObservable<Unit> Delete(long repositoryId, long commentId, long reactionId);
}
}
6 changes: 3 additions & 3 deletions Octokit.Reactive/Clients/IObservableGistCommentsClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public interface IObservableGistCommentsClient
/// <returns>IObservable{GistComment}.</returns>
[SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get",
Justification = "Method makes a network request")]
IObservable<GistComment> Get(string gistId, int commentId);
IObservable<GistComment> Get(string gistId, long commentId);

/// <summary>
/// Gets all comments for the gist with the specified id.
Expand Down Expand Up @@ -51,7 +51,7 @@ public interface IObservableGistCommentsClient
/// <param name="commentId">The id of the comment</param>
/// <param name="comment">The updated body of the comment</param>
/// <returns>IObservable{GistComment}.</returns>
IObservable<GistComment> Update(string gistId, int commentId, string comment);
IObservable<GistComment> Update(string gistId, long commentId, string comment);

/// <summary>
/// Deletes the comment with the specified gist- and comment id.
Expand All @@ -60,6 +60,6 @@ public interface IObservableGistCommentsClient
/// <param name="gistId">The id of the gist</param>
/// <param name="commentId">The id of the comment</param>
/// <returns>IObservable{Unit}.</returns>
IObservable<Unit> Delete(string gistId, int commentId);
IObservable<Unit> Delete(string gistId, long commentId);
}
}
28 changes: 14 additions & 14 deletions Octokit.Reactive/Clients/IObservableIssueCommentReactionsClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,54 +17,54 @@ public interface IObservableIssueCommentReactionsClient
/// <remarks>https://developer.github.com/v3/reactions/#create-reaction-for-an-issue-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <param name="reaction">The reaction to create </param>
IObservable<Reaction> Create(string owner, string name, int number, NewReaction reaction);
IObservable<Reaction> Create(string owner, string name, long commentId, NewReaction reaction);

/// <summary>
/// Creates a reaction for a specified Issue Comment
/// </summary>
/// <remarks>https://developer.github.com/v3/reactions/#create-reaction-for-an-issue-comment</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <param name="reaction">The reaction to create </param>
IObservable<Reaction> Create(long repositoryId, int number, NewReaction reaction);
IObservable<Reaction> Create(long repositoryId, long commentId, NewReaction reaction);

/// <summary>
/// List reactions for a specified Issue Comment
/// </summary>
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-an-issue-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The comment id</param>
IObservable<Reaction> GetAll(string owner, string name, int number);
/// <param name="commentId">The comment id</param>
IObservable<Reaction> GetAll(string owner, string name, long commentId);

/// <summary>
/// List reactions for a specified Issue Comment
/// </summary>
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-an-issue-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <param name="options">Options for changing the API response</param>
IObservable<Reaction> GetAll(string owner, string name, int number, ApiOptions options);
IObservable<Reaction> GetAll(string owner, string name, long commentId, ApiOptions options);

/// <summary>
/// List reactions for a specified Issue Comment
/// </summary>
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-an-issue-comment</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The comment id</param>
IObservable<Reaction> GetAll(long repositoryId, int number);
/// <param name="commentId">The comment id</param>
IObservable<Reaction> GetAll(long repositoryId, long commentId);

/// <summary>
/// List reactions for a specified Issue Comment
/// </summary>
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-an-issue-comment</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <param name="options">Options for changing the API response</param>
IObservable<Reaction> GetAll(long repositoryId, int number, ApiOptions options);
IObservable<Reaction> GetAll(long repositoryId, long commentId, ApiOptions options);

/// <summary>
/// Deletes a reaction for a specified Issue Comment
Expand All @@ -75,7 +75,7 @@ public interface IObservableIssueCommentReactionsClient
/// <param name="commentId">The comment id</param>
/// <param name="reactionId">The reaction id</param>
/// <returns></returns>
IObservable<Unit> Delete(string owner, string name, int commentId, int reactionId);
IObservable<Unit> Delete(string owner, string name, long commentId, long reactionId);

/// <summary>
/// Deletes a reaction for a specified Commit Comment
Expand All @@ -85,6 +85,6 @@ public interface IObservableIssueCommentReactionsClient
/// <param name="commentId">The comment id</param>
/// <param name="reactionId">The reaction id</param>
/// <returns></returns>
IObservable<Unit> Delete(long repositoryId, int commentId, int reactionId);
IObservable<Unit> Delete(long repositoryId, long commentId, long reactionId);
}
}
24 changes: 12 additions & 12 deletions Octokit.Reactive/Clients/IObservableIssueCommentsClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,20 +18,20 @@ public interface IObservableIssueCommentsClient
/// <remarks>http://developer.github.com/v3/issues/comments/#get-a-single-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="id">The issue comment id</param>
/// <param name="commentId">The issue comment id</param>
[SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get",
Justification = "Method makes a network request")]
IObservable<IssueComment> Get(string owner, string name, int id);
IObservable<IssueComment> Get(string owner, string name, long commentId);

/// <summary>
/// Gets a single Issue Comment by id.
/// </summary>
/// <remarks>http://developer.github.com/v3/issues/comments/#get-a-single-comment</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="id">The issue comment id</param>
/// <param name="commentId">The issue comment id</param>
[SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get",
Justification = "Method makes a network request")]
IObservable<IssueComment> Get(long repositoryId, int id);
IObservable<IssueComment> Get(long repositoryId, long commentId);

/// <summary>
/// Gets Issue Comments for a repository.
Expand Down Expand Up @@ -202,34 +202,34 @@ public interface IObservableIssueCommentsClient
/// <remarks>http://developer.github.com/v3/issues/comments/#edit-a-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="id">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <param name="commentUpdate">The modified comment</param>
IObservable<IssueComment> Update(string owner, string name, int id, string commentUpdate);
IObservable<IssueComment> Update(string owner, string name, long commentId, string commentUpdate);

/// <summary>
/// Updates a specified Issue Comment.
/// </summary>
/// <remarks>http://developer.github.com/v3/issues/comments/#edit-a-comment</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="id">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <param name="commentUpdate">The modified comment</param>
IObservable<IssueComment> Update(long repositoryId, int id, string commentUpdate);
IObservable<IssueComment> Update(long repositoryId, long commentId, string commentUpdate);

/// <summary>
/// Deletes the specified Issue Comment
/// </summary>
/// <remarks>http://developer.github.com/v3/issues/comments/#delete-a-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="id">The comment id</param>
IObservable<Unit> Delete(string owner, string name, int id);
/// <param name="commentId">The comment id</param>
IObservable<Unit> Delete(string owner, string name, long commentId);

/// <summary>
/// Deletes the specified Issue Comment
/// </summary>
/// <remarks>http://developer.github.com/v3/issues/comments/#delete-a-comment</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="id">The comment id</param>
IObservable<Unit> Delete(long repositoryId, int id);
/// <param name="commentId">The comment id</param>
IObservable<Unit> Delete(long repositoryId, long commentId);
}
}
4 changes: 2 additions & 2 deletions Octokit.Reactive/Clients/IObservableIssueReactionsClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public interface IObservableIssueReactionsClient
/// <param name="issueNumber">The issue number</param>
/// <param name="reactionId">The reaction id</param>
/// <returns></returns>
IObservable<Unit> Delete(string owner, string name, int issueNumber, int reactionId);
IObservable<Unit> Delete(string owner, string name, int issueNumber, long reactionId);

/// <summary>
/// Deletes a reaction for a specified Issue
Expand All @@ -85,6 +85,6 @@ public interface IObservableIssueReactionsClient
/// <param name="issueNumber">The issue number</param>
/// <param name="reactionId">The reaction id</param>
/// <returns></returns>
IObservable<Unit> Delete(long repositoryId, int issueNumber, int reactionId);
IObservable<Unit> Delete(long repositoryId, int issueNumber, long reactionId);
}
}
Loading
Loading