Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2693 PageCount doesn't work if the query gets constructed with page number as the first query parameter #2911

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

andrew-from-toronto
Copy link
Contributor

Resolves #2693

Before the change?

  • PageCount did not work if the query gets constructed with page number as the first query parameter

After the change?

  • PageCount now works if the query gets constructed with page number as the first query parameter

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@andrew-from-toronto andrew-from-toronto changed the title Fix #2693 Fix #2693 PageCount doesn't work if the query gets constructed with page number as the first query parameter Apr 23, 2024
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your attention to testing!

@kfcampbell kfcampbell merged commit a317340 into octokit:main Apr 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
2 participants