-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat]: Add RenameBranch method to RepositoryBranchesClient #2799
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dirtygooback Thanks for the adds here! ❤️
Would you mind converting your tabs to spaces? Optionally you can set you fork to maintainer writes and I can get it knocked out!
Thanks again!
if you like spaces over tabs that's on you :) The fork should already allow edits by maintainer |
Heh, it's not that I prefer them one way or the others, it's that the entire project favors spaces. We should really have a linter that checks for this and warns. As far as allowing edits by maintainers - I am getting the following which typically means that a user-owned fork does not allow edits from maintainers. I'll try making the changes outside of a code space to see if that's the issue. |
Let me know if I need to do anything to the repo. Happy to help |
@nickfloyd - Did you ever get this resolved? |
I did not. It seems for whatever reason I cannot push commits to your fork. Assuming your settings on the fork align with what's detailed here, I have no idea what's going on. The options are:
At this point, I could go either way. The functionality here is good and would provide value, which I am more interested in getting value to the community over trying to stick with a standard, but I am blocked today with our other duties and won't be able to get to the changes needed until tomorrow. Sorry for the trouble - if you feel compelled to make the spacing changes that would be awesome, but I understand our lack of enforced protocol is making this a bit more inconvenant . Let me know what you'd be up for, I am good either way and really just want the value shipped. |
@nickfloyd - It's not my repo so I changed the tabs to spaces. Hope I got them all. I do agree that if this is something that needs to be enforced, a linter will go a long way. I'm a TABs guy :) :) |
@nickfloyd - is there anything more that needs to be done to this PR before it gets merged? |
He gave permission as the issue has been fixed.
Resolves #ISSUE_NUMBER
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!