Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: Add RenameBranch method to RepositoryBranchesClient #2799

Merged
merged 5 commits into from
Oct 30, 2023

Conversation

SlyckLizzie
Copy link
Contributor

@SlyckLizzie SlyckLizzie commented Oct 4, 2023

Resolves #ISSUE_NUMBER


Before the change?

  • The RenameBranch method was not available on the RepositoryBranchClient object

After the change?

  • The Rename Branch method has been added to the RepositoryBranchClient object

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@nickfloyd nickfloyd added Type: Feature New feature or request hacktoberfest Issues for participation in Hacktoberfest labels Oct 11, 2023
@nickfloyd nickfloyd changed the title [feat] Add RenameBranch method to RepositoryBranchesClient [feat]: Add RenameBranch method to RepositoryBranchesClient Oct 11, 2023
Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dirtygooback Thanks for the adds here! ❤️

Would you mind converting your tabs to spaces? Optionally you can set you fork to maintainer writes and I can get it knocked out!

Thanks again!

@SlyckLizzie
Copy link
Contributor Author

if you like spaces over tabs that's on you :) The fork should already allow edits by maintainer

@nickfloyd
Copy link
Contributor

if you like spaces over tabs that's on you :) The fork should already allow edits by maintainer

Heh, it's not that I prefer them one way or the others, it's that the entire project favors spaces. We should really have a linter that checks for this and warns.

As far as allowing edits by maintainers - I am getting the following which typically means that a user-owned fork does not allow edits from maintainers. I'll try making the changes outside of a code space to see if that's the issue.

Screenshot 2023-10-11 at 1 39 59 PM

@ddaniels-andmore
Copy link

Let me know if I need to do anything to the repo. Happy to help

@SlyckLizzie
Copy link
Contributor Author

@nickfloyd - Did you ever get this resolved?
image

@nickfloyd
Copy link
Contributor

I did not. It seems for whatever reason I cannot push commits to your fork. Assuming your settings on the fork align with what's detailed here, I have no idea what's going on.

The options are:

  1. I let this in and then do a quick follow up with the fixes to make sure the repo remains standardized and add a linter to prevent this in the future.
  2. You make the changes in your fork and I merge it in and put an item in the backlog for a linter to enforce this.

At this point, I could go either way. The functionality here is good and would provide value, which I am more interested in getting value to the community over trying to stick with a standard, but I am blocked today with our other duties and won't be able to get to the changes needed until tomorrow. Sorry for the trouble - if you feel compelled to make the spacing changes that would be awesome, but I understand our lack of enforced protocol is making this a bit more inconvenant .

Let me know what you'd be up for, I am good either way and really just want the value shipped.

@SlyckLizzie
Copy link
Contributor Author

@nickfloyd - It's not my repo so I changed the tabs to spaces. Hope I got them all. I do agree that if this is something that needs to be enforced, a linter will go a long way. I'm a TABs guy :) :)

@SlyckLizzie
Copy link
Contributor Author

@nickfloyd - is there anything more that needs to be done to this PR before it gets merged?

@kfcampbell kfcampbell dismissed nickfloyd’s stale review October 30, 2023 21:50

He gave permission as the issue has been fixed.

@kfcampbell kfcampbell merged commit 335632b into octokit:main Oct 30, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Issues for participation in Hacktoberfest Type: Feature New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants