-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic codespaces api #2722
Add basic codespaces api #2722
Conversation
@kfcampbell @nickfloyd could you folks take a look? Thanks! |
@asklar I've approved the Actions workflow, which should get you some information about the test error. |
thanks @kfcampbell ! I had forgotten to make the client type public :) (it was marked internal) |
it's failing because the Observable client doesn't expose these. @kfcampbell Is there a way to say "sorry, not supported at the moment through the reactive wrapper, use the other one"? |
@kfcampbell I've pushed an empty IObservableCodespacesClient, hopefully this works now : ) |
conventions tests was failing, I've fixed it now. Sorry for the back and forth :) @kfcampbell |
another one |
@kfcampbell @nickfloyd sorry to bug you, could you kick the ci? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this @asklar! ❤️ LGTM!
Resolves #2721
Behavior
Before the change?
After the change?
Other information
Additional info
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Type: Breaking change
label)If
Yes
, what's the impact:Pull request type
Please add the corresponding label for change this PR introduces:
Type: Bug
Type: Feature
Type: Documentation
Type: Maintenance