Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing workflow run conclusions #2685

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Add missing workflow run conclusions #2685

merged 1 commit into from
Mar 24, 2023

Conversation

ezhevita
Copy link
Contributor

@ezhevita ezhevita commented Mar 19, 2023

Resolves #2684


Behavior

Before the change?

  • The property to get a workflow run conclusion throws an exception when trying to get value of the workflow run with the conclusion of startup_failure or skipped.

After the change?

  • The property returns the workflow run conclusion correctly and doesn't throw an exception.

Other information

  • I've mentioned in the original issue that GitHub documentation doesn't include these values as well, so it will be great if you pass this information internally to the docs team 😄

Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

@ezhevita
Copy link
Contributor Author

also GitHub doesn't seem to allow me to add a label to the PR, so if someone adds it for me I'll be happy 😁
the appropriate label is Type: Bug

@nickfloyd nickfloyd added Priority: Normal Type: Feature New feature or request labels Mar 24, 2023
Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ezhevita, Thanks for the work here ❤️ . We're still chatting about the API docs and the need for the enum values to be surfaced in a more visible way but this change is a solid addition to the SDK, thanks again for doing it!

@nickfloyd nickfloyd merged commit 7349ecd into octokit:main Mar 24, 2023
@ezhevita ezhevita deleted the ezhevita/add-missing-run-conclusions branch March 25, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: Missing workflow run conclusions
2 participants