Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly deserialize CollaboratorPermissionResponse #2682

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Correctly deserialize CollaboratorPermissionResponse #2682

merged 1 commit into from
Mar 10, 2023

Conversation

heaths
Copy link
Contributor

@heaths heaths commented Mar 10, 2023

Fixes #2681

@heaths
Copy link
Contributor Author

heaths commented Mar 10, 2023

/cc @JimSuplizio

@nickfloyd
Copy link
Contributor

nickfloyd commented Mar 10, 2023 •
edited
Loading

Hey @heaths, I am taking a look at this now... thank you for jumping on this so quickly. I missed it in my review the other day; apologies for that oversight! ❤️

nickfloyd
nickfloyd approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the going the extra mile with tests and a fixture ❤️

@nickfloyd nickfloyd added Priority: High Type: Bug Something isn't working as documented labels Mar 10, 2023
@nickfloyd nickfloyd merged commit 7f11726 into octokit:main Mar 10, 2023
@heaths heaths deleted the issue2681 branch March 10, 2023 18:15
@heaths
Copy link
Contributor Author

heaths commented Mar 10, 2023

Might we see a 5.1.1 in the near-ish future? For now we used the legacy PCollaboratorPermissionResponse.Permission string property but seems the new, more granular permission model gives us the better access we need than checking for "admin" or "write" - now we can just test if the nested "push" is true.

/cc @JimSuplizio who is working on incorporating this new version into our bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickfloyd nickfloyd nickfloyd approved these changes

Assignees
No one assigned
Labels
Type: Bug Something isn't working as documented
Projects
🧰 Octokit Active
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Octokit.net v5 doesn't deserialize user permissions response correctly
2 participants
@heaths @nickfloyd