Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pending WorkflowRunStatus #2657

Merged
merged 2 commits into from
Jan 23, 2023
Merged

Add pending WorkflowRunStatus #2657

merged 2 commits into from
Jan 23, 2023

Conversation

beliakov-mb
Copy link
Contributor

Resolves #2656


Behavior

Before the change?

WorkflowRunStatus enum does not contain "pending" value.

After the change?

WorkflowRunStatus enum contains "pending" value.

Other information


Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

@kfcampbell
Copy link
Member

@beliakov-mb do you mind pointing me towards the API documentation where this is defined? I see that in the List workflow runs for a workflow API, potential statuses are defined as:

Can be one of: completed, action_required, cancelled, failure, neutral, skipped, stale, success, timed_out, in_progress, queued, requested, waiting

Does "pending" correspond to "waiting"? Maybe "requested"?

@beliakov-mb
Copy link
Contributor Author

beliakov-mb commented Jan 19, 2023

Indeed, this condition is not in the documentation, but I get it from the github rest api, and catch the error (look at the attached issue)

I'll try to investigate how to reproduce such state.

@kfcampbell
Copy link
Member

Oh gosh, that's a hassle. I would definitely be curious how to trigger it!

@nickfloyd
Copy link
Contributor

@beliakov-mb Thanks for catching this and getting an update in here... I'm going to reach out to our docs team to make sure this get's updated. ❤️

@nickfloyd nickfloyd added Priority: Normal Type: Bug Something isn't working as documented labels Jan 23, 2023
@nickfloyd nickfloyd merged commit e3e27bb into octokit:main Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: WorkflowRunStatus enum does not contain "pending" value.
3 participants