Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2618 - Improve docs for the 'release' chapter #2628

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Fix #2618 - Improve docs for the 'release' chapter #2628

merged 1 commit into from
Dec 1, 2022

Conversation

Move2win
Copy link
Contributor

@Move2win Move2win commented Dec 1, 2022 •
edited
Loading

Resolves #2618

Behavior

After the change?

  • None code changes.

Other information

  • Fix the sample code for "Get All" not working.
  • Add the "Get Latest" section.

Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change (I can't add)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

@Move2win
Fix sample code and add 'get latest' section
2c7b13c 
1. Fix the sample code for "Get All" not working.
2. Add the "Get Latest" section.
@Move2win Move2win marked this pull request as ready for review December 1, 2022 14:14
kfcampbell
kfcampbell approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing!

@kfcampbell kfcampbell merged commit 64614ce into octokit:main Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfcampbell kfcampbell kfcampbell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Example code for getting all releases doesn't work
2 participants
@Move2win @kfcampbell