Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Fix API URLs for GitHub Enterprise Server #2626

Merged
merged 3 commits into from
Dec 1, 2022
Merged

[bug] Fix API URLs for GitHub Enterprise Server #2626

merged 3 commits into from
Dec 1, 2022

Conversation

martincostello
Copy link
Contributor

@martincostello martincostello commented Nov 30, 2022 •
edited
Loading

Behavior

Before the change?

  • API calls to GitHub Enterprise Server would fail with an HTTP 406 response.

After the change?

  • API calls to GitHub Enterprise Server succeed.

Other information

  • Looks like the leading / snuck in when support was added for packages, and was then copy-pasted without being noticed for subsequent methods added to the class, such as for the Actions workflow clients in Add Actions workflow API clients #2429.

Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

  • Yes (Please add the Type: Breaking change label)
  • No

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

@martincostello
Fix API URLs for GHES
bb73414 
Fix leading slashes causing API calls to fail when used with GitHub Enterprise.
@martincostello
Fix tests
53ffc24 
Fix tests that should have been updated in the previous commit.
@martincostello martincostello marked this pull request as ready for review November 30, 2022 10:12
kfcampbell
kfcampbell approved these changes Nov 30, 2022
View reviewed changes
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for doing this.

@kfcampbell kfcampbell merged commit 9780938 into octokit:main Dec 1, 2022
@martincostello martincostello deleted the fix-workflows-client branch December 1, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfcampbell kfcampbell kfcampbell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martincostello @kfcampbell