-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Environments API - GetAll list only feature #2613
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, things look good here. Just a comment about the tests and also you'll need to add an interface to the Reactive Project - Octokit.Reactive.IObservableRepositoryDeployEnvironmentsClient
we keep these in parity with the sync SDK APIs and interfaces. Let me know if you need any help with any of this! Thanks again for the contributions!
@nickfloyd hi! |
@nickfloyd also I wanted to let you know, that I was trying to implement CreateEnvironment method but figured out, that API call described in the documentation does not work for me. DeleteEnvironment call works fine, by the way. Maybe I've done something wrong, but if you'll have some time please check it too. Maybe there is a bug in Github API itself. |
Hey @semyon-p thanks for the updates! My guess on |
Value was either too large or too small for an Int32. at System.Convert.ThrowInt32OverflowException() |
Let's add Environment API support.
#2329
As a 1st step I've implemented GetAll methods for Environments.