Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splitting out the misc client into separate clients as per current documentation #2574

Merged
merged 2 commits into from
Sep 20, 2022
Merged

Splitting out the misc client into separate clients as per current documentation #2574

merged 2 commits into from
Sep 20, 2022

Conversation

JonruAlveus
Copy link
Collaborator

Splitting out Miscellaneous client into new clients.

  1. Split clients and interfaces
  2. Redirect misc client to new interfaces
  3. Obsolete methods with descriptions
  4. Repeat for Observable
  5. Duplicate unit tests
  6. Duplicate integration tests

@JonruAlveus
Copy link
Collaborator Author

@SeanKilleen @timrogers @nickfloyd I've made a start, let me know if there's anything glaring (the build will likely fail but I've gotta go!).

@JonruAlveus
Copy link
Collaborator Author

All done. Emojis and Meta endpoints didn't work before and don't work now, that can be dealt with separately. I believe Emojis already has a PR but might need to be done again.

@SeanKilleen
Copy link
Contributor

@JonruAlveus probably makes sense to file an additional issue about emoji and meta endpoints not working and why. 👍 Nice work on this!

@JonruAlveus JonruAlveus changed the title WIP Splitting out the misc client into separate clients as per current documentation Splitting out the misc client into separate clients as per current documentation Sep 17, 2022
@JonruAlveus
Copy link
Collaborator Author

Thanks @SeanKilleen, I have both raised issues and PRs :)

nickfloyd
nickfloyd approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this knocked out! 🎉

@nickfloyd nickfloyd merged commit 3c05db4 into octokit:main Sep 20, 2022
@nickfloyd
Copy link
Contributor

release_notes: Splits out the misc client into separate clients as per current documentation

@nickfloyd nickfloyd mentioned this pull request Sep 20, 2022
Merged
This was referenced Oct 7, 2022
Merged
Merged
Closed
Closed
Merged
Merged
Merged
Closed
Merged
@nickfloyd nickfloyd added Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR and removed category: housekeeping labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickfloyd nickfloyd nickfloyd approved these changes

Assignees
No one assigned
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JonruAlveus @SeanKilleen @nickfloyd