Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove /en slug in docs.github.com links (and stop VSCode from formatting on save) #2573

Merged
merged 2 commits into from
Sep 20, 2022
Merged

Remove /en slug in docs.github.com links (and stop VSCode from formatting on save) #2573

merged 2 commits into from
Sep 20, 2022

Conversation

SeanKilleen
Copy link
Contributor

Supports #2474

  • Updates vs code settings file to stop format on save
  • Removes /en from the existing docs.github.com links

@SeanKilleen
Copy link
Contributor Author

@nickfloyd here's a smaller, targeted PR to start us off. Ready for review.

JonruAlveus
JonruAlveus approved these changes Sep 16, 2022
View reviewed changes
Copy link
Collaborator

@JonruAlveus JonruAlveus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@nickfloyd nickfloyd merged commit 05aa951 into octokit:main Sep 20, 2022
@nickfloyd
Copy link
Contributor

release_notes: Removes /en slug in docs.github.com links (and stop VSCode from formatting on save)

@nickfloyd
Copy link
Contributor

Thanks for taking this on and getting things started with docs here @SeanKilleen! You're a 🦸!

This was referenced Oct 7, 2022
Merged
Merged
Closed
Closed
Merged
Merged
Merged
Closed
Merged
@nickfloyd nickfloyd added Type: Documentation Improvements or additions to documentation and removed category: docs-and-samples labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonruAlveus JonruAlveus JonruAlveus approved these changes

Assignees
No one assigned
Labels
Type: Documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SeanKilleen @nickfloyd @JonruAlveus