Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] update code docs for SetRequestTimeout #2520

Merged

Conversation

notauserx
Copy link
Contributor

@notauserx notauserx commented Aug 3, 2022

updating code docs to reflect what SetConnectionTimeout does. Fixes #2506

Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this 🥇 !!!!

@notauserx
Copy link
Contributor Author

My pleasure, @nickfloyd.

@nickfloyd nickfloyd merged commit 4d46d5f into octokit:main Aug 3, 2022
@nickfloyd
Copy link
Contributor

release_notes: Updates code docs for SetRequestTimeout to more appropriately reflect what the method does.

@notauserx notauserx deleted the update-documentaion-for-SetRequestTimeout branch August 3, 2022 15:34
@nickfloyd nickfloyd added Type: Documentation Improvements or additions to documentation and removed category: docs-and-samples labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct SetRequestTimeout code does to be more descriptive of what it's actually doing
2 participants