Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding App slug tests #2477

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Adding App slug tests #2477

merged 1 commit into from
Jul 14, 2022

Conversation

JonruAlveus
Copy link
Collaborator

Fixes #2335

Adds tests to cover the recently added github app slug field.

nickfloyd
nickfloyd approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for the follow-up on this! You rock man! ❤️

@nickfloyd nickfloyd merged commit d15517d into octokit:main Jul 14, 2022
@JonruAlveus JonruAlveus deleted the AddSlugTests branch July 21, 2022 04:43
@nickfloyd nickfloyd added Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR Type: Feature New feature or request and removed category: housekeeping labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickfloyd nickfloyd nickfloyd approved these changes

Assignees
No one assigned
Labels
Type: Feature New feature or request Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitHubApp should include slug
2 participants
@JonruAlveus @nickfloyd