Adding in handling for secondary rate limit exceptions #2473
Conversation
Octokit/Http/Connection.cs
Outdated
| @@ -719,7 +719,7 @@ static Exception GetExceptionForForbidden(IResponse response) | |||
| { | |||
| string body = response.Body as string ?? ""; | |||
|
|
|||
| if (body.Contains("rate limit exceeded")) | |||
| if (body.Contains("rate limit exceeded") || body.Contains("secondary rate limit")) | |||
There was a problem hiding this comment.
I wonder if it might be better throw a different kind of exception for a secondary rate limit. What do you think? I'm just thinking that it would make it easier to handle this specific case as a caller, without doing string matching.
There was a problem hiding this comment.
I get where you are coming from, makes sense to me :)
There was a problem hiding this comment.
I’d just define a new exception and raise that. It should be a quick change, and then we can get this approved and merged ✅
There was a problem hiding this comment.
I've changed it to be it's own exception.
There was a problem hiding this comment.
This looks good to me. Let me just tag in @nickfloyd who is more of a C# expert than me, and then we can get this merged hopefully. Thanks for your contribution ❤️
| @@ -180,7 +180,7 @@ public async Task ThrowsApiValidationExceptionFor422Response() | |||
| } | |||
|
|
|||
| [Fact] | |||
| public async Task ThrowsRateLimitExceededExceptionForForbidderResponse() | |||
|
release_notes: Adds handling for secondary rate limit exceptions from the GitHub REST API |
nickfloyd
added
Type: Feature
fixes #2466