Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fixed emojis return type #2458

Closed
wants to merge 1 commit into from

Conversation

briangtn
Copy link

There is a problem with the current return type of github emojis endpoint.
At the moment MiscellaneousClient.GetAllEmojis() try to return this data format:

[
	  {
		"name": "+1",
		"url": "https://github.githubassets.com/images/icons/emoji/unicode/1f44d.png?v8"
	  },
	...
]

But the current github api format is:

{
	"+1": "https://github.githubassets.com/images/icons/emoji/unicode/1f44d.png?v8"
	"-1": "https://github.githubassets.com/images/icons/emoji/unicode/1f44e.png?v8",
	...
}

The consequence is that MiscellaneousClient.GetAllEmojis() currently returns an empty set.
So I've updated octokit in order to use the new Github API response format and fix MiscellaneousClient.GetAllEmojis()

@briangtn briangtn changed the title Fixed emojis return type [WIP] Fixed emojis return type Jun 13, 2022
@JonruAlveus
Copy link
Collaborator

Hi @briangtn, do you plan to return to this PR would you be happy if it was completed by another contributor?

@JonruAlveus
Copy link
Collaborator

Replaced with #2577.

@nickfloyd nickfloyd added Type: Bug Something isn't working as documented and removed category: bug labels Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants