Add method to check if repo vulnerability alerts are enabled

[lboynton]

Just reopening #2334, is anyone able to review what would need to be done integration test wise to get this merged?

[nickfloyd]

Hey @lboynton thank you for your effort here and a huge apology for the delay in getting some 👀 on it. I made a few comments about no longer needing the preview header for the API call (the preview was promoted in 09/2021) - so you can remove those and use the default if you'd like.

✅ As far as integration tests - I think you might be ok there - you've got coverage for the client there as well as unit tests... thanks for doing those!

❇️ You could add the positive (204) and negative (404) tests for the GET endpoint
❇️ If you wanted to/ or had time you could add the other CRUP ops (PUT and DELETE)

❌ Also, there seems to be a merge conflict, but that should go away once you remove the preview changes.

Thanks again! Looking forward to getting this in.

[nickfloyd]

The dorian preview was promoted in 09/2021. This header is no longer needed to be passed over. Additionally, this endpoint is versioned for api.github.com only, it doesn't need an enterprise implementation and therefore can be completely removed from this SDK. Let me know if you have any questions regarding the state of previews.

[lboynton]

Removed

[lboynton]

Thanks for reviewing @nickfloyd! I've merged in the upstream changes in main to resolve the conflicts.

You could add the positive (204) and negative (404) tests for the GET endpoint

I believe these are already there in the TheAreVulnerabilityAlertsEnabledMethod class?

If you wanted to/ or had time you could add the other CRUP ops (PUT and DELETE)

I might leave that to a separate PR for me or someone else :)

[nickfloyd]

This looks good! Thank you again for the contributions here! ✅

[lboynton]

Thanks! :)

[cesarmorteo]

cool

[nickfloyd]

release_notes: Add method to check if repo vulnerability alerts are enabled