Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swift language #2344

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Add Swift language #2344

merged 1 commit into from
Aug 23, 2021

Conversation

p-brito
Copy link
Contributor

@p-brito p-brito commented Jul 14, 2021

No description provided.

@p-brito
Copy link
Contributor Author

p-brito commented Jul 14, 2021

@shiftkey can you review pls!?

@jpam87
Copy link

jpam87 commented Jul 14, 2021

@shiftkey pls do, I want that 2

@p-brito
Copy link
Contributor Author

p-brito commented Jul 14, 2021

@p-brito
Copy link
Contributor Author

p-brito commented Jul 14, 2021

#2341

@p-brito
Copy link
Contributor Author

p-brito commented Jul 15, 2021

@ryangribble @hahmed @hnrkndrssn anyone?

@p-brito
Copy link
Contributor Author

p-brito commented Jul 15, 2021

@alanjrogers

@khellang
Copy link
Contributor

khellang commented Jul 17, 2021

@p-brito
Copy link
Contributor Author

p-brito commented Jul 17, 2021

@khellang If nobody solves the issues what do you expect? Of course, people will open PR's :) If octokit does return Language Swift when you search for repositories why doesn't this allow you to search by it?! I understand what you sent, but we are talking about an enum value that probably someone forgot to add. Also, from what I can see the repository is not updated in months. How long it will take to create a patch to solve bugs? Bugs can be solved and the community doesn't need to wait for major or minor versions. https://semver.org

@khellang
Copy link
Contributor

Of course it's OK to send PRs with missing enum values, but tagging 4 people on the issue and 7 people on the PR would be considered nagging (by me) and isn't really helpful.

The maintainers of this library has other things to do in their lives than merging your PRs. Please respect that 😅

@p-brito
Copy link
Contributor Author

p-brito commented Jul 17, 2021

@khellang if no one answers it's normal that I tag people. If you open an issue to a repo where I am, I will answer you. Ofc, everyone has other things to do :) But that is the responsibility when you have a solution that is advertised and recommended by GitHub to interact with the API. I hope that these problems are addressed in a patch one day. Have a great day! Ty for answering!

@shiftkey shiftkey merged commit b829a84 into octokit:main Aug 23, 2021
@nickfloyd
Copy link
Contributor

release_notes: Adds Swift to the language type enum so that it can be used when searching for repositories

@nickfloyd nickfloyd added Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR and removed category: housekeeping labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants