Fixes #2143 - Support listing branch/pr per commit

[zacdirect]

No description provided.

[codecov]

Codecov Report

Merging #2315 (faae216) into main (15887d9) will decrease coverage by 0.30%.
The diff coverage is 23.58%.

❗ Current head faae216 differs from pull request most recent head c5ce60d. Consider uploading reports for the commit c5ce60d to get more accurate results

@@            Coverage Diff             @@
##             main    #2315      +/-   ##
==========================================
- Coverage   65.99%   65.68%   -0.31%     
==========================================
  Files         554      555       +1     
  Lines       14519    14625     +106     
  Branches      857      857              
==========================================
+ Hits         9582     9607      +25     
- Misses       4779     4860      +81     
  Partials      158      158              

Impacted Files	Coverage Δ
Octokit/Helpers/AcceptHeaders.cs	100.00% <ø> (ø)
Octokit/Models/Response/CommitPullRequest.cs	0.00% <0.00%> (ø)
Octokit/Clients/RepositoryCommitsClient.cs	84.37% <50.00%> (-15.63%)	⬇️
...tive/Clients/ObservableRepositoryCommitsClients.cs	88.40% <60.00%> (-11.60%)	⬇️
Octokit/Helpers/ApiUrls.cs	97.33% <75.00%> (-0.20%)	⬇️

[zacdirect]

I'm happy to make any adjustments. The one major thing I was on the fence about was creating a new model for CommitPullRequests. It could easily be returned as the existing PullRequest model, but in sampling some responses from GitHub I was never getting information back for the properties I removed. If their absence is possibly explained by a different preview header or license level then it would make sense to return them as the existing PullRequest model. I was unable to find any documentation explaining the difference so I opted for a new model to make it clear those PullRequest properties will never be there for these calls.

[github-actions]

'👋 Hey Friends, this pull request has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!'

[zacdirect]

Is this repo still active?

…

On Tue, May 10, 2022, 4:37 PM github-actions[bot] ***@***.***> wrote: '👋 Hey Friends, this pull request has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!' — Reply to this email directly, view it on GitHub <#2315 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOBO7I3AL45FLCLXL6AJC6DVJLJK3ANCNFSM4ZXK46VA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[timrogers]

Is this repo still active?

Yes!

[matt-richardson]

Can we re-open this PR and look to get it merged?

[kfcampbell]

I've reopened the PR and fixed the merge conflict.

[nickfloyd]

Everything looks good, thank you for these contributions! ❤️ . I just left one comment about the preview header. Not a show stopper, but it's essentially dead code and unnecessary, given REST API previews were deprecated last year. We can remove the code in this PR or do a follow-up if needed.

[nickfloyd]

Previews were deprecated last year for the REST API, so this header is no longer needed.

[kfcampbell]

I've removed the offending header!

[matt-richardson]

Hi @nickfloyd - is there anything stopping this one from being merged?

[nickfloyd]

Hi @nickfloyd - is there anything stopping this one from being merged?

I think it's g2g. Let me give it a once over and get it merged in. Apologies for the delay.

[nickfloyd]

LGTM ❤️