Add license to repository search #2258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2258 +/- ##
==========================================
- Coverage 65.98% 65.16% -0.83%
==========================================
Files 553 553
Lines 14428 14408 -20
Branches 843 841 -2
==========================================
- Hits 9521 9389 -132
+ Misses 4748 4744 -4
- Partials 159 275 +116
|
|
release_notes: |
nickfloyd
added
Type: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Search Repositories by license is supported by github api:
https://help.github.com/articles/searching-repositories#search-by-license
Currently only a list of licenses is supported as stated in :
https://docs.github.com/en/free-pro-team@latest/github/creating-cloning-and-archiving-repositories/licensing-a-repository#searching-github-by-license-type.
But using GitHub search I was able to find more licenses types keys.
https://github.com/search/advanced
This PR, adds all licenses found right now on GitHub.
One of the issues found while developing is that Octokit.License class does exist, while Octokit.Langues exist inside SearchRepositoriesRequest.cs and is also used on different classes I think we should move it later, for this PR I named the enum that has the licenses as : Octokit.RepoSearchLicense, the name can change, also I took the "license" word of the description of the enum, but I can put it back if needed.
Also test were added :)