Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missed props for organization #2239

Merged
merged 2 commits into from
Feb 13, 2021
Merged

feat: add missed props for organization #2239

merged 2 commits into from
Feb 13, 2021

Conversation

FrediKats
Copy link
Contributor

Organizations do not have some properties from https://developer.github.com/v3/orgs/ like description. Add missed properties for correct result parsing.

@codecov
Copy link

codecov bot commented Aug 16, 2020

Codecov Report

Merging #2239 into main will decrease coverage by 0.10%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2239      +/-   ##
==========================================
- Coverage   65.95%   65.85%   -0.11%     
==========================================
  Files         553      553              
  Lines       14449    14471      +22     
  Branches      843      843              
==========================================
  Hits         9530     9530              
- Misses       4760     4782      +22     
  Partials      159      159              
Impacted Files Coverage Δ
Octokit/Models/Response/Organization.cs 3.44% <0.00%> (-10.84%) ⬇️
Octokit/SimpleJson.cs 63.35% <0.00%> (-0.40%) ⬇️
Octokit.Reactive/Helpers/ObservableExtensions.cs 93.20% <0.00%> (+2.91%) ⬆️

Copy link
Member

@shiftkey shiftkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @InRedikaWB!

@shiftkey shiftkey merged commit 6755553 into octokit:main Feb 13, 2021
@shiftkey
Copy link
Member

release_notes: Additional properties added to Organization response

@nickfloyd nickfloyd added Type: Bug Something isn't working as documented and removed category: bug labels Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants