Deserialize requested_action field on check_run events. #2197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2197 +/- ##
==========================================
- Coverage 65.88% 65.03% -0.85%
==========================================
Files 546 547 +1
Lines 14293 14278 -15
Branches 838 835 -3
==========================================
- Hits 9417 9286 -131
Misses 4718 4718
- Partials 158 274 +116
|
|
@shiftkey what is the process to get this reviewed? |
|
@mitchdenny a bit of patience - aiming to throw some spare time on the weekend towards these side projects as Life™ and Work™ have been hectic this past week. |
shiftkey
approved these changes
Jun 5, 2020
There was a problem hiding this comment.
Thanks for the contribution @mitchdenny!
I'm aiming to cut a release over the weekend to test out some infrastructure changes, so I'll ensure this goes out with that...
|
Thbaks @shiftkey |
|
release_notes: Deserialize |
nickfloyd
added
Type: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #2195. It adds support for handling the
requested_actionfield when present on Check Run event payloads. This field is documented in the developer docs, but wasn't exposed in Octokit for .NET:https://developer.github.com/webhooks/event-payloads/#check_run