Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace emojis with Unicode characters #2169

Merged
merged 1 commit into from
Apr 11, 2020
Merged

Replace emojis with Unicode characters #2169

merged 1 commit into from
Apr 11, 2020

Conversation

nxtn
Copy link
Contributor

@nxtn nxtn commented Apr 5, 2020

@codecov
Copy link

codecov bot commented Apr 5, 2020

Codecov Report

Merging #2169 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2169      +/-   ##
==========================================
- Coverage   65.83%   65.81%   -0.03%     
==========================================
  Files         545      545              
  Lines       14234    14234              
  Branches      834      834              
==========================================
- Hits         9371     9368       -3     
- Misses       4706     4708       +2     
- Partials      157      158       +1     
Impacted Files Coverage Δ
Octokit.Reactive/Helpers/ObservableExtensions.cs 90.29% <0.00%> (-2.92%) ⬇️

Copy link
Member

@shiftkey shiftkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great find, @NextTurn - thanks for submitting the fix!

@shiftkey shiftkey merged commit 2bfd101 into octokit:master Apr 11, 2020
@nxtn nxtn deleted the emojis branch April 12, 2020 02:09
@shiftkey
Copy link
Member

release_notes: Updated GitHub Apps documentation to render emoji correctly

@nickfloyd nickfloyd added Type: Documentation Improvements or additions to documentation and removed category: docs-and-samples labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants