remove all usages of TaskFactory in test suite #2164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2164 +/- ##
=======================================
Coverage 66.75% 66.75%
=======================================
Files 545 545
Lines 14234 14234
=======================================
Hits 9502 9502
Misses 4732 4732 |
|
release_notes: replace |
nickfloyd
added
Type: Maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task.Factory.StartNewis from a time before we had the ability to wrap a result in aTask, and as part of simplifying tests to be able to refactor the internals I decided to drop these usages.You may also note the
TestSetup.GetApiResponsehelper function - that helps eliminate repetitive code and make the tests more readable.