Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first pass at cleaning up attributes #2157

Merged
merged 2 commits into from
Mar 18, 2020
Merged

first pass at cleaning up attributes #2157

merged 2 commits into from
Mar 18, 2020

Conversation

shiftkey
Copy link
Member

@shiftkey shiftkey commented Mar 18, 2020

This builds upon #2124 now that I've given it a first pass at auditing using the octokit/routes schema

  • review diff

@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #2157 into master will not change coverage by %.
The diff coverage is 75.00%.

@@           Coverage Diff           @@
##           master    #2157   +/-   ##
=======================================
  Coverage   66.73%   66.73%           
=======================================
  Files         545      545           
  Lines       14233    14233           
=======================================
  Hits         9498     9498           
  Misses       4735     4735           
Impacted Files Coverage Δ
Octokit/Clients/AssigneesClient.cs 88.88% <ø> (ø)
Octokit/Clients/AuthorizationsClient.cs 56.03% <ø> (ø)
Octokit/Clients/BlobsClient.cs 100.00% <ø> (ø)
Octokit/Clients/CheckRunsClient.cs 90.69% <ø> (ø)
Octokit/Clients/CheckSuitesClient.cs 90.32% <ø> (ø)
Octokit/Clients/CommitCommentReactionsClient.cs 100.00% <ø> (ø)
Octokit/Clients/CommitStatusClient.cs 100.00% <ø> (ø)
Octokit/Clients/CommitsClient.cs 100.00% <ø> (ø)
Octokit/Clients/DeploymentStatusClient.cs 100.00% <ø> (ø)
Octokit/Clients/DeploymentsClient.cs 100.00% <ø> (ø)
... and 46 more

@shiftkey shiftkey marked this pull request as ready for review March 18, 2020 11:58
@shiftkey shiftkey merged commit dc2f6ff into master Mar 18, 2020
@shiftkey shiftkey deleted the cleanup-attributes branch March 18, 2020 12:02
@shiftkey
Copy link
Member Author

shiftkey commented Mar 26, 2020

release_notes: Tidy up route metadata attributes based on schema information.

@nickfloyd nickfloyd added Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR and removed category: housekeeping labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants